-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/e2e #414
Dev/e2e #414
Conversation
37021a9
to
fba926e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Soare-Robert-Daniel Things look good from the e2e tests perspective.
Any reason we're removing the caching steps?
We're removing the yarn cache as well. I don't think that we have that many or heavy dependencies in this particular repo, but I still think caching them would be useful as a general practice. We can maybe look into updating the action to a more recent version: https://github.com/actions/cache?tab=readme-ov-file#example-cache-workflow Up to you if you consider the dependencies might be worth caching. Otherwise, the PR looks good. |
@abaicus, I Did a little research and found out that setup-node has a built-in cache on top of This should simplify the approach https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-data |
@Soare-Robert-Daniel Great! That's pretty neat 👍🏻 |
af87006
to
c6e6300
Compare
🎉 This PR is included in version 33.0.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Add E2E test infrastructure.
Will affect visual aspect of the product
NO
Check before Pull Request is ready:
Closes #411